-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a CI build for double precision #669
Add a CI build for double precision #669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need both Release and Debug builds with this setting?
I am absolutely on board with adding this. If hardware resources were not a concern, I could imagine just doubling the number of our tests outright. Adding one more "axis" to our test matrix.
Actually, should we try that? @paulgessinger, I guess you may have the most experience here. With how slow our CI may become if we throw so much work at it. 🤔
No, running it for Debug only would be ideal for the current setting. I just could not find a elegant way to exclude the Release build And I think it is going to be too much if we double the amount of tests. I am here assuming that successful tests with the FP32 also guarantee the success with the FP64, hopefully |
69bcf0a
to
f0508af
Compare
The easy way to do this would be using the In short, you'd add something like this: include:
- platform:
- name: CUDA
container: ghcr.io/acts-project/ubuntu2404_cuda:56
cxx_standard: "20"
options: -DTRACCC_CUSTOM_SCALARTYPE=double -DDETRAY_CUSTOM_SCALARTYPE=double -DTRACCC_BUILD_CUDA=TRUE -DCMAKE_CUDA_FLAGS="-std=c++20"
run_tests: false
build: Release |
@krasznaa Is this on the github or the gitlab side? |
9545b2d
to
588b840
Compare
Yepp, Pandora's box... 😦 Because of the issues, it could still make sense to set up It doesn't need to be this PR though. You'll have plenty of work with just making the core (and CUDA) code work correctly like this. We can take care of fixing up everything else in follow-up PRs. |
588b840
to
87421d8
Compare
While making this work, I also removed the awkward scalar type dependency in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just a bit uncertain about the simulation changes. Everything else I'm very much on board with. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, let's go then! 😄
b1daa2b
to
8388e40
Compare
8388e40
to
2f3cfd6
Compare
2f3cfd6
to
41bd4f8
Compare
We need to make sure that the traccc is compiled normally for the double precision